added explicit dependencies #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking care of this @jo-mueller! |
Cryaaa
reviewed
Nov 13, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
=======================================
Coverage 76.52% 76.52%
=======================================
Files 16 16
Lines 1853 1853
=======================================
Hits 1418 1418
Misses 435 435 ☔ View full report in Codecov by Sentry. |
|
@jo-mueller, |
This was referenced Nov 28, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#268
This adds a few dependencies to the
setup.cfgthat are, according to @goanpeca, imported in the plugin but not explicitly declared in the dependencies. Examples are, for instance,magicgui,scikit-imageandscipy`, all of which are dependencies of napari and thus not explicitly declared although they should be.