Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional explanation regarding zero as a label #270

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

stefanhahmann
Copy link
Contributor

* This was motivated by running into unexpected behaviour when using a label image and a measurement table that used `0` as a label, cf.: #269
@jo-mueller
Copy link
Collaborator

Hi @stefanhahmann ,

I think this should be good to go, thanks for spotting and opening the issue. Where I am concerned: Feel free to merge!

@zoccoler zoccoler added this to the 0.7.4 milestone Dec 6, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9398680) 76.38% compared to head (779cac0) 76.39%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
+ Coverage   76.38%   76.39%   +0.01%     
==========================================
  Files          16       16              
  Lines        1859     1860       +1     
==========================================
+ Hits         1420     1421       +1     
  Misses        439      439              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cryaaa
Copy link
Collaborator

Cryaaa commented Dec 11, 2023

Since tests are now passing after updating from main this is good to go!

@Cryaaa Cryaaa merged commit 7a5286e into main Dec 11, 2023
8 checks passed
@Cryaaa Cryaaa deleted the extend_readme_zero_labels branch January 23, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants