Add wombat COVID rules to OpenFisca #191
Conversation
year. The test fails, but I'm not sure what the desired outcome is meant to be. At least it doesn't crash anymore!
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
@asgharkazi @sarafalamaki we're keen to do some work around this - could you update the fork to be up-to-date with ServiceInnovationLab:master? |
|
I can't make changes to the |
openfisca_aotearoa/tests/social_security/covid_19_wage_subsidy.yaml
Outdated
Show resolved
Hide resolved
| decline_in_business_revenue_due_to_covid_19: True | ||
| already_applied_for_wage_subsidy: False | ||
| output: | ||
| covid_19_wage_subsidy__eligibility: True |
There was a problem hiding this comment.
| covid_19_wage_subsidy__eligibility: True | |
| covid_19_wage_subsidy__eligibility: False |
| already_applied_for_wage_subsidy: False | ||
| output: | ||
| covid_19_wage_subsidy__eligibility: True | ||
| - name: Sole trader, does not have IRD number, not eligible for wage subsidy |
There was a problem hiding this comment.
The tests here don't seem to match the name - have made suggestions on the relevant lines
| @@ -0,0 +1,26 @@ | |||
| - name: Sole trader, eligible for wage subsidy | |||
There was a problem hiding this comment.
These tests are both failing in CI - with the errors:
AssertionError: In test 'Sole trader, does not have IRD number, not eligible for wage subsidy', in file '/root/project/openfisca_aotearoa/tests/social_security/covid_19_wage_subsidy.yaml', covid_19_wage_subsidy__eligibility@2020-6: [0.] differs from 1.0 with an absolute margin [1.] > 0
There was a problem hiding this comment.
As below - some debugging with @JacOng17 reveals that it's because of the missing located_in_NZ parameter. If you make those changes, the tests should pass @asgharkazi @sarafalamaki
|
|
||
| roles=[ | ||
| { | ||
| 'key': 'business owner', |
There was a problem hiding this comment.
Is it a bit strange to have a space in this key?
| sole_trader_has_IRD_number: True | ||
| sole_trader_has_applicable_licenses: True | ||
| qualifications_or_registration_for_trade: True | ||
| registered_in_NZ: True |
There was a problem hiding this comment.
| registered_in_NZ: True | |
| registered_in_NZ: True | |
| located_in_NZ: True |
|
@asgharkazi @sarafalamaki we've made some suggestions that should get the tests passing - can you please have a look at them? |
….yaml Co-authored-by: Merrin Macleod <[email protected]>
….yaml Co-authored-by: Merrin Macleod <[email protected]>
No description provided.