temporary fix DropPodManager.cs #49
Conversation
| if (showMessage) | ||
| { | ||
| string messageString = "RimConnectionPositiveDroppodMailBody".Translate(amount, title, desc); | ||
| AlertManager.ResourceDropNotification(messageString, dropVector); | ||
| AlertManager.ResourceDropNotification(messageString, dropVector ?? DropCellFinder.TradeDropSpot(Find.CurrentMap)); |
There was a problem hiding this comment.
This is going to instantiate a new dropcell compared to the one that you fallback to on line 18. I'd suggest getting the variable dropVector to be a definite value, i.e. do the dropVector ?? DropCellFinder.TradeDropSpot(Find.CurrentMap) before dropping or writing the messages
There was a problem hiding this comment.
The meaning of this code was in safety and returning to old behavior in case the TryFindSafeLandingSpotCloseToColony method will return null, in theory this is possible, and I decided to play it safe. But in principle, this is not necessary.
There was a problem hiding this comment.
The function signature didn't seem to say it could return null and looks like it already falls back to "Can't find spot, dropping stuff randomly on the map". All good 😄, thank you very much for the PR . I gave it a good test and it works great
|
|
||
| if (showMessage) | ||
| { | ||
| string messageString = "RimConnectionPositiveDroppodMailBody".Translate("", title, desc); | ||
| AlertManager.ResourceDropNotification(messageString, dropVector); | ||
| AlertManager.ResourceDropNotification(messageString, dropVector ?? DropCellFinder.TradeDropSpot(Find.CurrentMap)); |
There was a problem hiding this comment.
Ditto previous comment
|
Thank you again for putting this branch up, I used what you wrote here and made some tweaks over in PR #50 |
#47