Update celery task names to match python path after refactor #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@Comeani in two instances you updated the task name, and in one instance the task specification. The first two cases should not work. Did you test this PR in any way? |
|
I see what you're saying, that's my bad for not testing it like I should have. I can make another PR to make it all consistent and make an explicit test as well. Would it be sufficient to make sure the tasks here are registered or should the task specification already match the name? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keystone's task logs report these tasks as erroring due to being unregistered after some recent refactoring of the tasks themselves.
Fixing their names in this way should cause the application to find them properly as registered again.