Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create LIT7276MarkOne.xml #1438

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Create LIT7276MarkOne.xml #1438

merged 2 commits into from
Feb 18, 2025

Conversation

CarstenHoffmannMarburg
Copy link
Contributor

According to our discussion in BetaMasaheft/Documentation#2804.

new/LIT7276MarkOne.xml Outdated Show resolved Hide resolved
new/LIT7276MarkOne.xml Outdated Show resolved Hide resolved
new/LIT7276MarkOne.xml Outdated Show resolved Hide resolved
<keywords>
<term key="Missal"/>
<term key="Prayers"/>
<term key="NewTestament"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This keyword is defined as "biblical books belonging to the New Testament" – I'm not sure if it fits here or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look to LIT6783MarkFive, which has the keywords Bible and NewTestament. I want to keep NewTestament and add Bible and ChristianLiterature. I think, it is better to have one keyword more than one keyword less. It is justified, because it is a prayer partly taken from a Biblical book.

<keywords>
                    <term key="Bible"/>
                    <term key="ChristianLiterature"/>
                    <term key="Magic"/>
                    <term key="NewTestament"/>
                </keywords>

@CarstenHoffmannMarburg CarstenHoffmannMarburg merged commit 8b05b12 into master Feb 18, 2025
1 check passed
@CarstenHoffmannMarburg CarstenHoffmannMarburg deleted the MarkOne_CH branch February 18, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants