Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Misc Fixes #279

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Minor Misc Fixes #279

merged 4 commits into from
Jun 11, 2024

Conversation

Eric-Vin
Copy link
Collaborator

Description

Adjusts a pruning test to be less difficult and fixes a Webots example to account for a change to the localPath function.

Issue Link

#261

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

N/A

@Eric-Vin Eric-Vin changed the title Minor Fixes for 3.0 Minor Misc Fixes Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (7126916) to head (ceb9c1a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
+ Coverage   91.27%   91.30%   +0.02%     
==========================================
  Files          54       54              
  Lines       13513    13520       +7     
==========================================
+ Hits        12334    12344      +10     
+ Misses       1179     1176       -3     

see 5 files with indirect coverage changes

@Eric-Vin Eric-Vin requested a review from dfremont June 11, 2024 14:43
Copy link
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, although I think we should fix the path manipulation (see above).

@Eric-Vin Eric-Vin requested a review from dfremont June 11, 2024 20:39
Copy link
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Eric-Vin Eric-Vin merged commit 0c667bd into main Jun 11, 2024
26 checks passed
@Eric-Vin Eric-Vin deleted the Eric_MinorFixes branch June 11, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

city_intersection worlds city_intersection.wbt file is broken when loaded into Webots
2 participants