Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding output gif for newtonian simulator #273

Merged
merged 12 commits into from
Jun 5, 2024

Conversation

abanuelo
Copy link
Contributor

@abanuelo abanuelo commented May 24, 2024

Description

As a way to illustrate dynamic scenarios more concretely in Google Colab, added a feature to show dynamic scenarios via an output gif. See the output gif when running:

scenic examples/driving/badlyParkedCarPullingIn.scenic -S -m scenic.simulators.newtonian.driving_model --2d
saved-gif.mov

Also I am adding that it works with Colab:

dynamic_newtonian.mov

Issue Link

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

@abanuelo abanuelo requested review from dfremont and Eric-Vin May 24, 2024 18:25
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@836b0f8). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage        ?   91.29%           
=======================================
  Files           ?       54           
  Lines           ?    13520           
  Branches        ?        0           
=======================================
  Hits            ?    12343           
  Misses          ?     1177           
  Partials        ?        0           
Files Coverage Δ
src/scenic/simulators/newtonian/simulator.py 89.94% <100.00%> (ø)

@Eric-Vin Eric-Vin merged commit 63725a3 into main Jun 5, 2024
26 checks passed
@Eric-Vin Eric-Vin deleted the abanuelo/add-gif-newtonian branch June 5, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants