Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updating examples for CARLA and driving domain #257

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

abanuelo
Copy link
Contributor

@abanuelo abanuelo commented May 6, 2024

Description

This PR:

  • Updates the necessary *.scenic example files for the CARLA and driving domain manual control from strings to integers
  • Testing was done on a Linux machine to see if the files were still working.
  • Python comments were added informing users how to run said files.

Issue Link

As a result of testing and implementing these changes, two issues were open:
#255
#256

This PR intends to workaround the issues rather than provide a direct fix.

Checklist

  • I have tested the changes locally via pytest and/or other means
  • [] I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

@abanuelo abanuelo requested review from dfremont and Eric-Vin May 6, 2024 23:18
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.23%. Comparing base (01af6b1) to head (f606883).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
+ Coverage   86.16%   86.23%   +0.06%     
==========================================
  Files         144      144              
  Lines       25007    25124     +117     
==========================================
+ Hits        21547    21665     +118     
+ Misses       3460     3459       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@lola831 lola831 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the updated instructions in CARLA, and everything worked as expected.

@lola831 lola831 merged commit ca74ae9 into main Dec 18, 2024
6 of 26 checks passed
@lola831 lola831 deleted the abanuelo/update-examples branch December 18, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants