-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding dynamic scenario and object creation tests for CARLA #227
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
==========================================
- Coverage 86.16% 86.15% -0.02%
==========================================
Files 144 146 +2
Lines 25007 25285 +278
==========================================
+ Hits 21548 21784 +236
- Misses 3459 3501 +42 ☔ View full report in Codecov by Sentry. |
…nuelo/add-carla-dynamic-scenario-tests
Important!!!!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall -- a few suggestions above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments (and one which I've unresolved from before).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good: just a couple last tweaks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Description
Adding the following three test cases:
BusStop
class withinmodel.scenic
that needed to be captured. Also note that these tests are automatically skipped as there are memory leak errors with Carla at the moment!Issue Link
Checklist
pytest
and/or other meansAdditional Notes