Improve test coverage and robustness #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the previously fragile unit tests for the command_line_t type with tests that no longer require launching an fpm subprocess via execute_command_line and checking that child process's exit status. The test main program also now prints instructions for how to run the command_line_t tests if the flags for running those tests is not detected.
rouson
changed the title
rouson
force-pushed
the
fix-commmand-line-tests
branch
from
2116e76 to
45441b5
Compare
This commit fixes some issues that led to crashes when searched-for flags are not present or the flag value is not present.
rouson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
command_line_ttype with tests that no longer require launching an fpm subprocess viaexecute_command_lineand checking that child process's exit status.command_line_ttests are not detected in thefpm testcommand, the main test program prints instructions for running thecommand_line_ttests ..smodgenerated submodule file extensions to the.gitignorefile.command_line_tunit tests.