Add awaiter implementation #133
Conversation
ds5678
added
generation
This comment was marked as outdated.
This comment was marked as outdated.
|
I investigated this pull request and what it's attempting to solve. I discovered that the type system improvements I mentioned above will not automatically fix the issue. As I understand it, the issue is that even if proper interface support is implemented with system interface support, only the Il2Cpp For the rewrite, I could see a generic implementation where all Il2Cpp I am willing to review this pull request once it has been ported to AsmResolver. |
Paste from ML plugin, will be changed to remove unnecessary code/comments & improve generic handling
- Use CorLibTypeFactory.Void for void reference - Added a couple more early-outs before LINQ - Use .Single - Use MemberCloner (and define a nested type for that) - Check method signature & forward to methods that may have been wonkily unhollowed
|
Whenever you're ready for another review, let me know. |
|
Ah yeah, if you can review again that'd be great |
- Use .Single for action conversion - Match interface using namespace (in addition to name) - Match method using .OriginalMethod.Name - Use SignatureComparer & change comment to reflect that - Make sure method is instanced - Remove nop opcodes
|
Apologies for the month of absence, it's ready for review again. I'm not too familiar with PRs, so if it needs to be brought up to date with main again, let me know. |
Instead of MemberCloner
|
Ready for review again! |
| // Used later for MemberCloner, just putting up here as an early exit in case .Module is ever null | ||
| if (typeContext.NewType.Module is null) | ||
| continue; |
|
@js6pak Do you have any feedback for this PR before I merge it? |
Adds
Pass61ImplementAwaitersLooks for types implementing
INotifyCompletionand generates new methods that allow the interop types to implement that interface, calling the Il2CppSystem.Action -> System.Action implicit conversion before calling the original method.This makes originally-awaitable types (e.g.
UniTasks, if the game has them) awaitable again.I previously did this in a much less automated way with Cecil in another project, but the runtime didn't like what I was doing, so I figured I'd make it less janky and add it to Il2CppInterop, and sure enough the runtime no longer rejects the type.