Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lore-length readded + Ability to set some GUI default colors #340

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

YellowZaki
Copy link

I think lore-length was a great addition. I know it was removed because of problems with some languages. That's why I've made it to be disabled if the user changes it to -1.

I've also added the ability to use default colors for challenge description text and rewards text. When you have a lot of challenges it is very tedious to start every text with the same color.

Tested and working.

            challenge:
                # The main part that generates description text.
                # [description] comes from challenge.description
                lore: |-
                    [description]
                    [status]
                    [cooldown]
                    [requirements]
                    [rewards]
                description:
                    # Formatting applied to description text ([description])
                    color: '&b'
rewards:
                    # [text] comes from challenge.rewardText and challenge.repeatRewardText
                    lore: |-
                        &7&l Rewards:
                        [text]
                        [items]
                        [experience]
                        [money]
                        [commands]
                    # Formatting applied to reward text ([text])
                    text-color: '&b'

@BONNe
Copy link
Member

BONNe commented May 23, 2024

hmm, but you can do it with description itself.
the reason it was removed was because it is not necessary....

The description of challenge:

&7line 1
&7Line 2
&7 line 3 with any length you want

This only makes sense, if users create description like:

&7 I will put everything in single line and hope it will be ok. Not sure why tho...

What I would suggest is to split the description text on saving/loading instead of parsing time.
The only I issue what I see is that it is not obvious that text will be split in that case.

@YellowZaki
Copy link
Author

hmm, but you can do it with description itself. the reason it was removed was because it is not necessary....

The description of challenge:

&7line 1
&7Line 2
&7 line 3 with any length you want

This only makes sense, if users create description like:

&7 I will put everything in single line and hope it will be ok. Not sure why tho...

What I would suggest is to split the description text on saving/loading instead of parsing time. The only I issue what I see is that it is not obvious that text will be split in that case.

I know that you can create multiline descriptions by manually splitting the text. But it is not convenient. You have to manually split it which takes time. By automatically adjusting it, it saves lot of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants