Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template.css #724

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

PeteHaughie
Copy link

I've been doing a lot of work with P5 visualisations which also use generated form elements. This small update brings the output in line with the overall Bela branding and forces the flex layout into a column format.

I've been doing a lot of work with P5 visualisations which also use generated form elements. This small update brings the output in line with the overall Bela branding and forces the flex layout into a column format.
@giuliomoro
Copy link
Contributor

giuliomoro commented Oct 11, 2023

Thanks for your contribution. I see the advantage in having GUIs (and text) that by default are styled closer to what is in the Bela IDE, however I am wondering if making this a default would break people's expectation, "why doesn't my GUI look like the example?". Maybe these should go in a dedicated css file that a keen user can load it from P5's preload() ?
E.g.:

function loadCss(src, parent, dom=document, module=false) {
    let promise = new Promise(function(resolve, reject) {
        let scriptElement = dom.createElement('link');
        scriptElement.setAttribute('type', 'text/css');
        scriptElement.setAttribute('rel', 'stylesheet');
        scriptElement.setAttribute('href', src);
        if(module) {
                scriptElement.setAttribute('type', 'module');
        }
        let parentElement = dom.getElementById(parent) || dom.head;

        parentElement.appendChild(scriptElement);
        scriptElement.onerror = (error) => {
            reject(null);
        }
        scriptElement.onload = () => {
            resolve(scriptElement);
        }
    });
    return promise;
}
function preload() {
        loadCss('css/template-bela.css');
}

(and we can make loadCss() a library function, just like we currently have loadScript()).

Finally, I am not sold on the "dark mode" defaults
Screenshot 2023-10-11 at 08 18 46

Good thing is that by making these loadable, we could have two, one for dark mode and one for bright mode.

@PeteHaughie
Copy link
Author

I'll have a look at implementing that and update the branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants