Rust-g IconForge: Lightning fast spritesheet generation #10404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not remove the TM without notifying me first |
|
Currently on the global player panel antag icons are broken, same for orbit menu it seems |
|
icons are slightly bigger |
itsmeow
added
Test Merged
PowerfulBacon
added
Test Merged
itsmeow
added
Testmerge Passed
PowerfulBacon
approved these changes
Jan 14, 2024
Crossedfall
reviewed
Jan 16, 2024
Crossedfall
approved these changes
Jan 24, 2024
|
Funny man says press the button so I'm pressing the button |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ss13-beebot
added a commit
that referenced
this pull request
Jan 28, 2024
DrDuckedGoose
pushed a commit
to DrDuckedGoose/BeeStation-Hornet
that referenced
this pull request
May 11, 2024
…0404) * Initial testing * Rustg icon generator * this thing.. fast.... * Fix * Finish porting spritesheets and add GAGS support * Remove 'moving' attribute * Refactor the DM component * Update rustg DM and add cleanup call * vendor_icon_preview -> icon_state_preview * Revert tracy change * Re-add GAGS to design spritesheet * Fix crafting spritesheet size * Correct webroot args * Adds caching * Reset rustg * Move cleanup step where it belongs * Add crosscompiled rustg dll * Log cache invalidations * Fix player panel and orbit spritesheets * Fix reading legacy sheets from cache * Enables local caching of legacy assets, adds Regenerate Asset Cache debug verb * Fix universal_icon creation being slow * Protect against cache deletion * Fix hand icons not displaying properly * Remove this very incorrect assumption * Restore rust_g to master * Update defs * Add rustg version checker to smart cache * Move legacy cache to data/spritesheets so it persists on prod * Update config comment to match * Copy all icons so CI works * Try fix CI again * Fix chat and designs not displaying properly when loaded from cache * Fix mistake * Fix double encoding * Inline uni_icon, saving unnecessary proc-call overhead * Create a unit test for the smart cache
DrDuckedGoose
pushed a commit
to DrDuckedGoose/BeeStation-Hornet
that referenced
this pull request
May 11, 2024
Trilbyspaceclone
pushed a commit
to sojourn-13/sojourn-station
that referenced
this pull request
May 30, 2024
* Update rust-g and fix spritesheet icon cache problem * Convert design_icons to spritesheet, from 1618 images to 8 * Update rust-g in the CI as well * Push ci suite to ubuntu 22.04 so that rust-g stops complaining * Update libssl too... oh jeez. * Fix PyYaml * Include rust-g in repo for CI * Stop CRASHing whenever the asset cache encounters a bad entry, it guarantees everything else will break * A whole bunch of bullshit to make IconForge work Ports BeeStation/BeeStation-Hornet#10404 * whoops this should be in the example config
Trilbyspaceclone
added a commit
to sojourn-13/sojourn-station
that referenced
this pull request
Jun 8, 2024
* Update rust-g, use spritesheet asset for design icons (#5315) * Update rust-g and fix spritesheet icon cache problem * Convert design_icons to spritesheet, from 1618 images to 8 * Update rust-g in the CI as well * Push ci suite to ubuntu 22.04 so that rust-g stops complaining * Update libssl too... oh jeez. * Fix PyYaml * Include rust-g in repo for CI * Stop CRASHing whenever the asset cache encounters a bad entry, it guarantees everything else will break * A whole bunch of bullshit to make IconForge work Ports BeeStation/BeeStation-Hornet#10404 * whoops this should be in the example config * Makes the close button on votes actually close the window (#5383) * oversight * Update vote.dm * Favor Title Correction (#5385) This has like, no gameplay impact whatsoever. Both ammo boxes are the same, lackluster price, but just had their names swapped around (A single number.) The game is now playable. * fixes missing/mislabled borg icons (#5391) * [balance] New burn-wound medicine (#5353) Adds a new chem for use in treating internal burns/necrosis. Created by mixing carbon, sulfuric acid and dermaline. Painful to use, but at least it doesn't require surgery. Trypsin can also be used to treat "permanent" scars but only via overdose- which will cause steady brute wounds similar to kyphotorin(and even more pain). This chem is partly an experiment in chem effect numbers that aren't flat values, but are determined by dose(a number that steadily goes up as you metabolize a reagent.) * saving xenobotany from itself (#5328) * saving xenobotany from itself - adds low-grade antitoxin chem, which heals tox like dylo but slower - adds monocaridine chem, which heals brute like bicard but slower - adds moon water chem, which heals burn like kelo but slower - adds moon tear plant, which has moon water. It mutates into sun tear. - adds space alocasia, which has monocaridine and low grade antitoxin. It mutates into mercy's hand - changed poppies to contain Monocaridine and space drugs instead of its previous reagents - changed ambrosia vulgaris to contain just monocaridine instead of kelotane and bicaridine - changed potatoes to mutate into blood root - Moon Tear added to seed vendors - Space Alocasia added to seed vendors - Blood root, Mercy's hand, and Sun tear removed from garden Seedmaster. * fix seed values Makes the new seeds & plants properly show * updates new stuff * brighten alocacia leaves --------- Co-authored-by: Trilbyspaceclone <[email protected]> * Remaps the engine chamber to allow for larger engines (#5331) * Remaps the engine chamber to allow for larger engines * Moves things where they won't be blocked * Adds camera * [Removal] Removes partial understanding on monkey for common and for common on monkey (#5335) * Removes another ancient reference to a gamemode that does not even exist anymore * Update monkey.dm * Integration bricking itself again one sec * Integration check * Troopers no longer have the option of the lascore (#5338) See title. the lascore was a cool gun that i was happy to give to the shield but it seems like it outshines most other options. Sgt/Corpsman may still select this option. * [balance] Contaminiated items respect bio_armor now (#5396) * Update life.dm * Update life.dm * is_worn() * it compiles faster on git * Ditch abiotic checks in scanner/cryo cell, make cryo eject dropped items (#5398) * note boards for bulk selling (#5397) * note boards for bulk selling * clearer instuctions * TEFs changes to xenobio/slimegun (#5394) * Second sanity check for Mechiver eating mechs (#5401) * mechivers no longer at mechs * second sanity check * Allows the church to make bioreactors from scratch (#5407) * Allows the church to make bioreactor from scratch Tiny fix for a big issue. Corrects a small pathing mistake in the manifest litany. Allowing church to create bioreactors from scratch. Removes the bioreactor tank manifest blueprint to avoid confusion. The tank platform makes it all on on its own. Pleases the machine god. * Update construction.dm fixes it for reals * Fix people spawning in spess by making them always spawn close to where they should before using put_mob (#5402) * More QOL for borgs and minor AI bugfix (#5388) it never ends * Xenohydro relayed out! (#5370) * Xenohydro relayed out! * apc * single new light * rather annoying fixes (#5373) * SLTs and sensors (#5392) * cold assets (#5390) * rounding (#5389) * Pouch "rebalance" (#5384) * modular pouches * sanity, better numbers and less exploits * large pouch tweaks * grammar * tweaked scaling * ear and large pouch * optimization * make tape not stick storage * small pouch nerf * Update tape.dm * Update code/game/objects/items/weapons/storage/pouches.dm * TGUI Guild Part 3 (#5376) * TGUI Guild P3: TEG  * TGUI Guild Part 3: Omni Devices (Filter/Mixer) * TGUI Guild Part 3: Air Monitoring Computer * TGUI Guild Part 3: Canisters * TGUI Guild Part 3: Gas Freezer/Heater * TGUI Guild Part 3: Portable Scrubber/Pump * TGUI Guild Part 3: Update FA for those sweet virus icons * TGUI Guild Part 3: Suit Storage Unit * TGUI Guild Part 3: ID Cards * TGUI Guild Part 3: Fix lathe queue icons, custom vending machines losing items * TGUI Guild Part 3: AI/Admin Airlock Controls * Fix the AI hotkeys for doors * Add a bunch of log_debugs to the new spawning code to try and nail down a problem (#5408) * Revert "Add a bunch of log_debugs to the new spawning code to try and nail do…" (#5411) This reverts commit 35b908e. * Adds armbands to Marshal and Blackshield wardrobes (#5413) * Revert "Fix people spawning in spess by making them always spawn close to whe…" (#5415) This reverts commit 49c3965. * KILL EM (#5418) * Fluff Item: TheEternalFlame's Duster --------- Co-authored-by: Dissent <[email protected]> Co-authored-by: WilsonWeave <[email protected]> Co-authored-by: Trilbyspaceclone <[email protected]> Co-authored-by: CDB <[email protected]> Co-authored-by: Hex <[email protected]> Co-authored-by: Spock <[email protected]> Co-authored-by: IrkallaEpsilon <[email protected]> Co-authored-by: Dimasw99 <[email protected]> Co-authored-by: benj8560 <[email protected]> Co-authored-by: WatermelonsEverywhere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Implements IconForge, from tgstation/rust-g#160
Requires #10408
IconForge is a speedier version of the existing spritesheet generator with smart caching, allowing it to be cached on local and in development. It's overall faster in every way, and avoids blocking the main thread whereever possible.
Adds the universal_icon framework, designed to imitate icon(), but for exporting to rustg. It also supports GAGS conversion to universal icons!
Also lightly optimizes legacy spritesheets in a few ways
Why It's Good For The Game
Lower init times, better development experience, less server compute time, less lag post-roundstart during asset generation.
Testing Photographs and Procedure
Screenshots&Videos
Overall performance
Cache validation cost
Local cache invalidated:
Changelog
🆑
refactor: Optimized asset generation greatly using rustg IconForge (also by itsmeow), greatly reducing post-initialization lag as well as reducing init times and saving server computation.
config: Added 'smart' asset caching, for batched rustg IconForge spritesheets. It is persistent and suitable for use on local, with automatic invalidation.
config: Enabled legacy asset caching for the two remaining spritesheets during local development.
add: Added Debug -> Regenerate Asset Cache verb for legacy spritesheets.
tweak: Replaced many uses of the slow md5asfile() function with rust-g based MD5.
code: Cleaned up the duplicate function vars vendor_icon_preview and icon_state_preview, removing vendor_icon_preview and moving icon_state_preview to /obj/item.
fix: Fixed some preferences icons cropping to incorrect scales.
server: The legacy spritesheet cache will no longer be cleared by TGS redeployments, instead the regenerate verb should be used, or delete the files from data/spritesheets/legacy_cache.
/:cl: