Minor changes to score improvement text (#45)

* simple visual fix, made negative improvements show as - rather than +-, also added % symbol to accuracy improvement (imo this should be replaced by FC acc/pp for parity)

* making this != is better

* honestly forgot this line, also added pp to the end

* made the improvement text easier to read

* now changes color depending on if the improvement is positive or negative

* should probably give these their own if checks

* cleaned it up, no more warnings or errors

* i missed some minor stuff lol

src/UI/ScoreDetails/GeneralScoreDetails.cpp

@@ -53,8 +53,8 @@ string FormatInt(int score) {
 string FormatScore(Score const& score) {
     string result = FormatInt(score.modifiedScore);
 
-    if (score.scoreImprovement.score > 0) {
-        result += "\n<color=#008800><size=55%>+" + FormatInt(score.scoreImprovement.score) + "</size></color>";
+    if (score.scoreImprovement.score != 0) {
+        result += (score.scoreImprovement.score > 0) ? ("\n<color=#20BB20><size=55%>+" + (FormatInt(score.scoreImprovement.score)) + "</size></color>") : "\n<color=#BB2020><size=55%>" + FormatInt(score.scoreImprovement.score) + "</size></color>";
     }
     return result;
 }
@@ -91,17 +91,17 @@ string GetDetailsString(const Score& score) {
 inline string FormatAcc(const Score& score) {
     string result = FormatUtils::formatAcc(score.accuracy);
 
-    if (score.scoreImprovement.score > 0) {
-       result += "\n<color=#008800><size=55%>+" + to_string_wprecision(score.scoreImprovement.accuracy * 100, 2) + "</size></color>";
+    if (score.scoreImprovement.accuracy != 0) {
+       result += (score.scoreImprovement.accuracy > 0) ? ("\n<color=#20BB20><size=55%>+" + (to_string_wprecision(score.scoreImprovement.accuracy * 100, 2)) + "%</size></color>") : "\n<color=#BB2020><size=55%>" + to_string_wprecision(score.scoreImprovement.accuracy * 100, 2) + "%</size></color>";
     }
 
     return result;
 }
 
 inline string FormatPP(const Score& score) {
     string result = FormatUtils::FormatPP(score.pp);
-    if (score.scoreImprovement.score > 0) {
-       result += "\n<color=#008800><size=55%>+" + to_string_wprecision(score.scoreImprovement.pp, 2) + "</size></color>";
+    if (score.scoreImprovement.pp != 0) {
+       result += "\n<color=#20BB20><size=55%>+" + to_string_wprecision(score.scoreImprovement.pp, 2) + "pp</size></color>";
     }
     return result;
 }