Skip to content

Update Python module to include versions 3.11.5, 3.11.6b0, and 3.12.6.0 with corresponding configurations and scripts #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

N6REJ
Copy link
Contributor

@N6REJ N6REJ commented Sep 18, 2024

User description

should only be for 3.12.6.0


PR Type

enhancement, configuration changes


Description

  • Added batch scripts and installation scripts for Python versions 3.11.5, 3.11.6b0, and 3.12.6.0 to ensure backward compatibility and facilitate installation.
  • Added configuration files and wheel properties for each Python version to specify executable paths and link to the pywin32 wheel.
  • Updated the bundle release date in the build.properties file.

Changes walkthrough 📝

Relevant files
Enhancement
6 files
python.bat
Add batch script for Python 3.11.5                                             

bin/python3.11.5/bin/python.bat

  • Added batch script for Python 3.11.5.
  • Ensures backward compatibility for command-line users.
  • +6/-0     
    install.bat
    Add installation script for Python 3.11.5                               

    bin/python3.11.5/wheel/install.bat

  • Added installation script for Python 3.11.5.
  • Installs pywin32 wheel.
  • +5/-0     
    python.bat
    Add batch script for Python 3.11.6b0                                         

    bin/python3.11.6b0/bin/python.bat

  • Added batch script for Python 3.11.6b0.
  • Ensures backward compatibility for command-line users.
  • +6/-0     
    install.bat
    Add installation script for Python 3.11.6b0                           

    bin/python3.11.6b0/wheel/install.bat

  • Added installation script for Python 3.11.6b0.
  • Installs pywin32 wheel.
  • +5/-0     
    python.bat
    Add batch script for Python 3.12.6.0                                         

    bin/python3.12.6.0/bin/python.bat

  • Added batch script for Python 3.12.6.0.
  • Ensures backward compatibility for command-line users.
  • +6/-0     
    install.bat
    Add installation script for Python 3.12.6.0                           

    bin/python3.12.6.0/wheel/install.bat

  • Added installation script for Python 3.12.6.0.
  • Installs pywin32 wheel.
  • +5/-0     
    Configuration changes
    7 files
    bearsampp.conf
    Add configuration for Python 3.11.5                                           

    bin/python3.11.5/bearsampp.conf

  • Added configuration file for Python 3.11.5.
  • Specifies executable paths and version.
  • +6/-0     
    wheel.properties
    Add wheel properties for Python 3.11.5                                     

    bin/python3.11.5/wheel/wheel.properties

  • Added wheel properties for Python 3.11.5.
  • Links to pywin32 wheel.
  • +1/-0     
    bearsampp.conf
    Add configuration for Python 3.11.6b0                                       

    bin/python3.11.6b0/bearsampp.conf

  • Added configuration file for Python 3.11.6b0.
  • Specifies executable paths and version.
  • +6/-0     
    wheel.properties
    Add wheel properties for Python 3.11.6b0                                 

    bin/python3.11.6b0/wheel/wheel.properties

  • Added wheel properties for Python 3.11.6b0.
  • Links to pywin32 wheel.
  • +1/-0     
    bearsampp.conf
    Add configuration for Python 3.12.6.0                                       

    bin/python3.12.6.0/bearsampp.conf

  • Added configuration file for Python 3.12.6.0.
  • Specifies executable paths and version.
  • +6/-0     
    wheel.properties
    Add wheel properties for Python 3.12.6.0                                 

    bin/python3.12.6.0/wheel/wheel.properties

  • Added wheel properties for Python 3.12.6.0.
  • Links to pywin32 wheel.
  • +1/-0     
    build.properties
    Update bundle release date                                                             

    build.properties

    • Updated bundle release date.
    +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    ….0 with corresponding configurations and scripts
    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    Version Mismatch
    The script is installing pywin32-306 for Python 3.12, but it's in a Python 3.11.5 directory

    Version Mismatch
    The script is installing pywin32-306 for Python 3.12, but it's in a Python 3.11.6b0 directory

    Version Mismatch
    The wheel URL points to a Python 3.12 version of pywin32, but it's in a Python 3.11.5 directory

    Version Mismatch
    The wheel URL points to a Python 3.12 version of pywin32, but it's in a Python 3.11.6b0 directory

    Copy link

    qodo-merge-pro bot commented Sep 18, 2024

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Use a wheel file specific to Python 3.11.5 for better version compatibility

    Consider using a more specific wheel file name that includes the Python version
    (3.11.5) instead of 3.12. This ensures compatibility with the correct Python
    version.

    bin/python3.11.5/wheel/install.bat [4]

    -"%WINPYDIR%\Scripts\pip.exe" install pywin32-306-cp312-cp312-win_amd64.whl
    +"%WINPYDIR%\Scripts\pip.exe" install pywin32-306-cp311-cp311-win_amd64.whl
     
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: The suggestion correctly identifies a potential compatibility issue by recommending a wheel file that matches the Python version 3.11.5, ensuring that the installed package is compatible with the intended Python version.

    9
    Use a wheel file compatible with Python 3.11.6b0

    Update the wheel file name to match the Python version 3.11.6b0 instead of 3.12 to
    ensure compatibility.

    bin/python3.11.6b0/wheel/install.bat [4]

    -"%WINPYDIR%\Scripts\pip.exe" install pywin32-306-cp312-cp312-win_amd64.whl
    +"%WINPYDIR%\Scripts\pip.exe" install pywin32-306-cp311-cp311-win_amd64.whl
     
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: This suggestion addresses a compatibility issue by recommending a wheel file that aligns with the Python version 3.11.6b0, which is crucial for ensuring the correct functioning of the installed package.

    9
    ✅ Use a wheel URL that matches the Python version of the module
    Suggestion Impact:The suggestion impacted the commit by changing the wheel URL to be compatible with Python 3.11, as suggested.

    code diff:

    @@ -1 +1 @@
    -wheel = https://github.com/Bearsampp/modules-untouched/releases/download/Python-2023.10.9/pywin32-306-cp312-cp312-win_amd64.whl
    +wheel = https://github.com/Bearsampp/modules-untouched/releases/download/python-2024.3.29/pywin32-306-cp311-cp311-win_amd64.whl

    Update the wheel URL to point to a version of pywin32 that is compatible with Python
    3.11.5 instead of 3.12.

    bin/python3.11.5/wheel/wheel.properties [1]

    -wheel = https://github.com/Bearsampp/modules-untouched/releases/download/Python-2023.10.9/pywin32-306-cp312-cp312-win_amd64.whl
    +wheel = https://github.com/Bearsampp/modules-untouched/releases/download/Python-2023.10.9/pywin32-306-cp311-cp311-win_amd64.whl
     
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: The suggestion accurately points out the need to update the wheel URL to match the Python version 3.11.5, which is important for ensuring that the correct version of the package is downloaded and installed.

    9
    ✅ Ensure the wheel URL corresponds to the correct Python version
    Suggestion Impact:The commit changed the wheel URL to be compatible with Python 3.11, aligning with the suggestion to ensure compatibility with Python 3.11.6b0.

    code diff:

    @@ -1 +1 @@
    -wheel = https://github.com/Bearsampp/modules-untouched/releases/download/Python-2023.10.9/pywin32-306-cp312-cp312-win_amd64.whl
    +wheel = https://github.com/Bearsampp/modules-untouched/releases/download/python-2024.3.29/pywin32-306-cp311-cp311-win_amd64.whl

    Modify the wheel URL to reference a pywin32 version compatible with Python 3.11.6b0
    instead of 3.12.

    bin/python3.11.6b0/wheel/wheel.properties [1]

    -wheel = https://github.com/Bearsampp/modules-untouched/releases/download/Python-2023.10.9/pywin32-306-cp312-cp312-win_amd64.whl
    +wheel = https://github.com/Bearsampp/modules-untouched/releases/download/Python-2023.10.9/pywin32-306-cp311-cp311-win_amd64.whl
     
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: This suggestion highlights the importance of modifying the wheel URL to reflect the Python version 3.11.6b0, ensuring compatibility and preventing potential issues with package installation.

    9

    💡 Need additional feedback ? start a PR chat

    @jwaisner jwaisner merged commit 24f43ee into main Oct 2, 2024
    @jwaisner jwaisner deleted the 3.12.6 branch October 2, 2024 02:25
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants