Update TeamTalk5.py #2411
Update TeamTalk5.py #2411
Conversation
Library/TeamTalkPy/TeamTalk5.py
Outdated
| @@ -1157,7 +1157,7 @@ def function_factory(func, signature): | |||
| _InitLocalPlayback = function_factory(dll.TT_InitLocalPlayback, [INT32, [_TTInstance, TTCHAR_P, POINTER(MediaFilePlayback)]]) | |||
| _UpdateLocalPlayback = function_factory(dll.TT_UpdateLocalPlayback, [BOOL, [_TTInstance, INT32, POINTER(MediaFilePlayback)]]) | |||
| _StopLocalPlayback = function_factory(dll.TT_StopLocalPlayback, [BOOL, [_TTInstance, INT32]]) | |||
| _GetMediaFileInfo = function_factory(dll.TT_GetMediaFileInfo, [BOOL, [TTCHAR_P, POINTER(MediaFileInfo)]]) | |||
| _GetMediaFileInfo = function_factory(dll.TT_GetMediaFileInfo, [BOOL, [_TTInstance, TTCHAR_P, POINTER(MediaFileInfo)]]) | |||
There was a problem hiding this comment.
Why did you modify this line? This function has no instance parameter.
There was a problem hiding this comment.
Sorry, the teamtalk py I made changes to was old, I think. I just realized that.
Library/TeamTalkPy/TeamTalk5.py
Outdated
| @@ -1634,10 +1652,6 @@ def acquireUserAudioBlock(self, uStreamTypes: StreamType, nUserID: int) -> POINT | |||
| def releaseUserAudioBlock(self, lpAudioBlock: POINTER(AudioBlock)) -> bool: | |||
| return _ReleaseUserAudioBlock(self._tt, lpAudioBlock) | |||
|
|
|||
| def getMediaFileInfo(szMediaFilePath) -> MediaFileInfo: | |||
| mfi = MediaFileInfo() | |||
There was a problem hiding this comment.
And this function should be fully restored.
Moreover, it is out of scope from this pull request to modify it in any manner.
|
I'll turn off this pull request and turn it back on. Sorry again. |
|
Or can changes be made without closing? I'll look into it. |
Make some tests locally but I think you should be able to make your modifications without closing, mark this pull request as draft while you look for a solution. |
|
Why did you request a review? Except if I missed something, you did not make any change... |
|
Sorry. Will you check it again now? |
|
I bought the latest TEAMTALKPY from the repo and updated the buildTextMessage function. |
|
Does this pull request fix high CPU usage in TTMediaBot? CC: @beqabeqa473 Can you review? |
Hello. This is my first contribution at GH. So please excuse me if I'm doing something wrong. As a result of my tests, I noticed that TeamTalk counts non-ASCII characters as extra characters when sending a message larger than 512 characters containing UTF-8 characters, that is, it sends the message incomplete. So I rolled up my sleeves and updated the buildTextMessage function so that it counts non-ASCII characters as extra characters when splitting a message.