Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missed startRecordingMuxedAudioFileEx and stopRecordingMuxedAudioFileEx #2277

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

safe-acid
Copy link

adding startRecordingMuxedAudioFileEx and stopRecordingMuxedAudioFileEx

@bear101
Copy link
Contributor

bear101 commented May 14, 2024

Hm, it has typos and I don't think there's a stopRecordingMuxedAudioFileEx() function

@safe-acid
Copy link
Author

safe-acid commented May 14, 2024

it is in TeamTalk.h
TEAMTALKDLL_API TTBOOL TT_StopRecordingMuxedAudioFileEx(IN TTInstance* lpTTInstance, IN INT32 nChannelID);

it could be utilized by "time.sleep" , stop is not required
example of usage
self.tt.startRecordingMuxedAudioFileEx(myChanneID, ttstr(audio_file_name), AudioFileFormat.AFF_WAVE_FORMAT) time.sleep(25)

should be kept only startRecordingMuxedAudioFileEx ?

removed - stoptRecordingMuxedAudioFileEx(self, nChannelID):
@bear101 bear101 marked this pull request as draft May 18, 2024 06:34
@bear101
Copy link
Contributor

bear101 commented May 18, 2024

The methods should be called startRecordingMuxedAudioFile() and stopRecordingMuxedAudioFile(). startRecordingMuxedAudioFile() should have default arguments and call TT_StartRecordingMuxedAudio() and TT_StartRecordingMuxedAudioEx() accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants