Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive combined text messages on Android #1287

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bear101
Copy link
Contributor

@bear101 bear101 commented Mar 30, 2022

@poretsky In TeamTalk v5.9 I've added 'bMore' member variable to TextMessage-class. When 'bMore' is set then the current message type (nMsgType) is part of a combined message. The combined TextMessage ends when 'bMore' is cleared (false).

Can you find a way for TextMessageAdapter to support this type of messages? Basically TextMessageAdapter should not update until all TextMessages with 'bMore' has been received.

@bear101 bear101 added this to the TeamTalk v5.9 milestone Mar 30, 2022
@bear101 bear101 requested a review from poretsky March 30, 2022 05:40
@bear101
Copy link
Contributor Author

bear101 commented Mar 30, 2022

@bear101
Copy link
Contributor Author

bear101 commented Mar 30, 2022

@beqabeqa473 Maybe you could also have a look at this

@bear101 bear101 removed this from the TeamTalk v5.10 milestone Jul 20, 2022
@bear101
Copy link
Contributor Author

bear101 commented May 14, 2023

This PR so far only does the merge part of TextMessage. TextMessageAdapter should not show the message until bMore=false.

Maybe it's enough to change TextMessageActivity.onCmdUserTextMessage() to not update if bMore=true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant