Fixed GameDir location issues. #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't launch the game without this.
WiserTixx
requested changes
Dec 6, 2024
Co-authored-by: Tixx <[email protected]>
Co-authored-by: Tixx <[email protected]>
Co-authored-by: Tixx <[email protected]>
Co-authored-by: Tixx <[email protected]>
|
I know the snap version has its libraryFolders, but for me they didn't find the gameDir for some reason, so I omitted their address. But if they worked with you, maybe something is miss configured on my end. Edit: miss configuration confirmed, |
lionkor
suggested changes
Dec 10, 2024
As requested: - Changed 'string' variables that referred to paths to 'filesystem'. - Added error log for when a valid 'GameDir' isn't found. Also readded error log for when 'libraryfolders.vdf' is missing for better contextualization for the 'basic_string::_M_replace_aux' error (the code doesn't reach the GameDir segment when that file is not found).
WiserTixx
requested changes
Dec 14, 2024
Johnny-Connor
force-pushed
the
game-dir-issues
branch
from
a86756f to
f2b86cd
Compare
Johnny-Connor
changed the title
WiserTixx
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't launch the game without this.
By creating this pull request, I understand that code that is AI generated or otherwise automatically generated may be rejected without further discussion.
I declare that I fully understand all code I pushed into this PR, and wrote all this code myself and own the rights to this code.