Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed custom volume slider to MPVolumeView #14

Merged
merged 4 commits into from
Jul 16, 2013
Merged

Changed custom volume slider to MPVolumeView #14

merged 4 commits into from
Jul 16, 2013

Conversation

DerPipo
Copy link
Contributor

@DerPipo DerPipo commented Jul 4, 2013

But there is a problem with running the tests for iPad (not introduced with this commit, but should be solved anyway): error: testPlaylistVisibility (BeamMusicPlayerViewControllerTests) failed: -[UIPopoverController presentPopoverFromRect:inView:permittedArrowDirections:animated:]: Popovers cannot be presented from a view which does not have a window.

As i mentioned before i'm new to writing tests and i've got no idea why viewController.view.window is nil in this test.

DerPipo added 3 commits July 5, 2013 00:32
Updated build settings (and schemes) to Xcode-recommended (and enabled warnings for undeclared selectors to avoid typos in @selector(...))
@DerPipo
Copy link
Contributor Author

DerPipo commented Jul 5, 2013

Which also means that the Travis CI build only tests for iPhone, i think. Could be another issue.

@HBehrens
Copy link
Member

HBehrens commented Jul 9, 2013

Thank you, Pipo. Before I merge this, could you do some adjustments?

  • Creating an MPVolumeView in InterfaceBuilder is possible by placing a UIView and manually set its class in the inspector. This would simplify the code. I did sth similar with the transparent toolbar in the bottom, please have a look.
  • Since MPVolumeView is not supported in the simulator, do you think a label "no sound control in simulator" or the like would make sense?

I will have a look at the unit-test issue, hence I created #16

Label is shown if running on simulator
@HBehrens HBehrens merged commit 0458be1 into BeamApp:master Jul 16, 2013
@HBehrens
Copy link
Member

Thanks :)

HBehrens added a commit that referenced this pull request Jul 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants