Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Fix for Releases #341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ddink
Copy link
Contributor

@ddink ddink commented Jan 31, 2025

What will it allow you to do that you can't do today?

beacon_live_admin retains the same functionality, but a potential blocker for releases is removed.

Why do you need this feature and how will it benefit other users?

While building a release of an umbrella application featuring beacon in one of the child apps and beacon_live_admin in another, I was running into a MatchError that was preventing the release from being started:

** (MatchError) no match of right hand side value: {:error, {:already_started, #PID<0.3898.0>}}
            (beacon_live_admin 0.1.0-dev) lib/beacon/live_admin/cluster.ex:21: Beacon.LiveAdmin.Cluster.init/1

By making this small edit, I enabled my release to start successfully.

Are there any drawbacks to this feature?

Not that I can tell. All of beacon_live_admin’s tests still run without failures. The umbrella application still runs successfully with mix phx.server. And the release is able to start without any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant