FileUpload plugin #198
Open
FileUpload plugin #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had issues with FileProbes plugin, and missed the capability of genshi templates, so I mixed up Bundler and FileProbes to have what I want. It is tested in 1.3.4 I don't know how version changes affect it. It basically works like Bundler plugin. There are some not so nice errors, and solutions in it. Sorry about that I'm not an expert in Python. I also made some extensions compared to the original one like handling missing groups and users (the original version just threw an exception in that case) Hope to be useful for someone, any comments and feedbacks are welcome
|
Can you explain briefly how to use this plugin, with some examples ideally? There's obviously a lot of duplicated code in here so we can't accept this as-is, but if you can give some guidance on how it's used I should be able to suggest ways that we can clean it up so that it can be accepted. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had issues with FileProbes plugin, and missed the capability of genshi
templates, so I mixed up Bundler and FileProbes to have what I want. It
is tested in 1.3.4 I don't know how version changes affect it. It
basically works like Bundler plugin. There are some not so nice error messages,
and solutions in it. Sorry about that I'm not an expert in Python. I
also made some extensions compared to the original one like handling
missing groups and users (the original version just threw an exception
in that case) Hope to be useful for someone, any comments and feedbacks
are welcome