Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Scala 2.13: cross builds for 2.11 and 2.12, all tests pass #283

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrade to Scala 2.13: cross builds for 2.11 and 2.12, all tests pass #283

wants to merge 1 commit into from

Conversation

orbang
Copy link

@orbang orbang commented Jul 9, 2021

Hi, I have upgraded cloudformation-template-generator to Scala 2.13. It still cross builds for 2.11 and 2.12. Changes:

  • The majority of changes are related to the MapView change in the collections API
  • ScalaTest patch version upgrade (the old one doesn't have 2.13 artifacts)
  • A workaround has been added for the JsonWritable implicit conversion, which is required because of implicit resolution changes in 2.13 (see comment)
  • Traversable has been removed in Scala 2.13, replaced with an Iterator based impl.

Would it be possible to publish artifacts for 2.13 at some point?

orbang
orbang commented Jul 9, 2021
View reviewed changes
src/main/scala/com/monsanto/arch/cloudformation/model/AwsStringInterpolation.scala

override def iterator: Iterator[A] =
if (parts.isEmpty)
Seq[A]().iterator
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scala 2.11 doesn't have Iterator.empty...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@orbang