-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Cognito #262
base: master
Are you sure you want to change the base?
Conversation
@@ -10,12 +10,13 @@ import spray.json._ | |||
|
|||
case class `AWS::AutoScaling::AutoScalingGroup`( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you shouldn't be specifying both AvailabilityZones and VPCZoneIdentifier. For maximum type safety we should make both optional and make the whole constructor private. Then we can add 2 new methods that instantiate a ASG with the different methods as well as a default for backwards compatibility in the companion. See AWS::EC2::EIP as an example.
@@ -0,0 +1,243 @@ | |||
package com.monsanto.arch.cloudformation.codegen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a really cool idea. Can you add some sort guide on how to use it to the README under a how to add new types section?
@chrisshafer I'm finally getting around to catching up on PRs here. Is this still something we'd like to see merged? I see @tj-corrigan had a couple comments. |
@bkrodgers likely, I'll see if I can find the time in the next couple weeks. |
AWS::AutoScaling::AutoScalingGroup
to support conditional AZ's and health checks.AWS::ECS::Service
Fixes: #165