Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the starter template for C++ #44

Merged
merged 2 commits into from
Aug 27, 2023

Conversation

OneBogdan01
Copy link
Contributor

@OneBogdan01 OneBogdan01 commented Apr 26, 2023

That repo does not work with the new API, it does not run at all on Replit

Also, I am confused about the pull request templates and I do not have the option to open an issue.
Edit: Also this link is not working (found in the contributing.md file)

That repo does not work with the new API
@OneBogdan01 OneBogdan01 requested review from a team as code owners April 26, 2023 15:59
@xtagon
Copy link

xtagon commented Apr 29, 2023

Hi @OneBogdan01,

Thank you for contributing! My personal opinion is that it would be better for someone to bring the C++ starter template up to date and fix any API incompatibilities/fix the documentation issues rather than to remove it entirely.

I see you already opened an issue on their repo here: DAChenScratch/Starter-Battlesnake-Cpp-with-replit#3

Because the Battlesnake docs repo doesn't allow creating issues, a more appropriate place would be the Battlesnake Discussions here: https://github.com/orgs/BattlesnakeOfficial/discussions

I'd be curious to see what others think. There might be someone else in the community who knows C++ and wants to help get things up to date.

@OneBogdan01
Copy link
Contributor Author

Hello! I completely agree with you. I think that remaking the C++ starter template would be ideal.

@xtagon
Copy link

xtagon commented Apr 30, 2023

I'm not too familiar with the modern C++ ecosystem. What is the recommended HTTP server for C++ these days?

@OneBogdan01
Copy link
Contributor Author

I am currently learning modern C++, but I have absolutely no experiene with http requests.

@bvanvugt bvanvugt merged commit 8378d69 into BattlesnakeOfficial:main Aug 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants