Please fix regex for fstab hook #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sions in fstab. Unfortunately it breaks scenarios where no options are provided as the current regex expects the comma with the options always to be present. This patch fixes the regex to handle the options as group.
|
There is already a PR addressing this. Are you saying you would like to have the option to supply “no options” at all? |
No, I hope I didn’t come across the wrong way. I definitely want to be able to specify the mount permissions (ro, rw, etc.). However, without my patch, the issue is that something like... produces an validation error. |
|
I see. We are testing the above PR, which only greps to make sure one of [rw|ro|rq|sw|xx] is included according to fstab documentation. Can you test that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit fb71f0d introduced to possibility to add options behind permissions
in fstab. Unfortunately it breaks scenarios where no options are provided
as the current regex expects the comma with the options always to be present.
This patch fixes the regex to handle the options as group.