Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: jcp for copying jail to jail #805

Merged
merged 23 commits into from
Jan 27, 2025

Conversation

tschettervictor
Copy link
Collaborator

@tschettervictor tschettervictor commented Jan 12, 2025

#552 asked for jail to jail copy mode.

EDIT
cp stays the same
rcp stays the same

NEW: jcp command added

'bastille jcp jail /path/file jail1 /path' will copy from "jail" to "jail1" or whatever jails are specified.

To test

Make sure cp is functional
Make sure rcp is functional
Make sure jcp is functional

You can cp and jcp to all jails using "ALL". rcp works only on one jail though, as it copies from a jail to host.

@bmac2
Copy link
Collaborator

bmac2 commented Jan 14, 2025

tested all options, -r, -j and regular cp. All work as advertised.

@yaazkal whenever you can test this one.

@bmac2
Copy link
Collaborator

bmac2 commented Jan 21, 2025

for discussion here are the two options I see to remain consistent.

What this pr is currently, cp command with switches for remote copy and jail to jail copy and cp with no switches for normal copy. So cp with all the switches.

IF we want to keep rcp and cp then create jcp for jail to jail copy.

Those are the two ways we are consistent and still give everyone the jail to jail copy that was requested.

@yaazkal
Copy link
Collaborator

yaazkal commented Jan 27, 2025

@tschettervictor I've just rebased

@yaazkal
Copy link
Collaborator

yaazkal commented Jan 27, 2025

@tschettervictor can you please rebase as the master branch has changes? Thanks

@yaazkal yaazkal changed the title Feature: Cp rcp new functions and documentation New: jcp for copying jail to jail Jan 27, 2025
@tschettervictor
Copy link
Collaborator Author

Done.

@yaazkal
Copy link
Collaborator

yaazkal commented Jan 27, 2025

Done.

Thanks!

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@yaazkal yaazkal merged commit bba1056 into BastilleBSD:master Jan 27, 2025
1 check passed
@tschettervictor tschettervictor deleted the cp-rcp-new-functions branch January 27, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants