mount: allow mount with options behind permissions

[tschettervictor]

Allow mounting with permissions like “rw,other,options” that are needed for tmpfs mounting.

[yaazkal]

I'll keep the current code. There is no gain in that change and we lost readability.

[tschettervictor]

I'll keep the current code. There is no gain in that change and we lost readability.

Hmm...
We lose a lot without this, namely #504

Current code does not allow mounting with any options other than ro and rw

Thoughts?

[yaazkal]

Sorry @tschettervictor I read it wrong. Reopening for testing.

[bmac2]

tested good. This does fix the #504 issue with tmp filesystems.

[yaazkal]

My comment to this change is that the user will be forced to always use ro or rw as the first option, is that how it should be? If so let's add that in documentation.

[tschettervictor]

You bring a valid point.

You are right.

We could either do docs, or do a small tweak to make sure rw or ro is always included in the options.

[bmac2]

do we need to unmerge this one and make that change?? Force them to use rw or ro? or is documentation enough?
@yaazkal @tschettervictor

[tschettervictor]

I've just submitted PR #801 documenting the behaviour.

[yaazkal]

@bmac2 I'll say documentation is enough thinking in the release.

But not sure about if it's preferable by the community to not be force to start wit ro, rw. Anyway is almost an "standard" to have those as the first option.

But if we think if border scenarios, not sure if anyone is using swap mounts, in that case, that will never work as the option is sw or read with quotas wich option is rq (Not sure if those also are valid for jails). Check fstab(5)

[yaazkal]

That said in my previous comment, why we don't make the second option Victor said: check that the basic options are included, in this case as per fstab(5):

"rw": read/write device
"rq": read/write with quotas
"ro": read-only device
"sw": swap device
"xx": ignore totally

That way, we bring a wide solution rather than an different limitation to the subcommand.

What do you think?

[bmac2]

fine by me. @tschettervictor you good with coding that up for this release?

[tschettervictor]

Simple enough. Give me an hour or so to implement it.

[tschettervictor]

#802 @yaazkal