Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shellcheck: general linting and github action #763

Merged
merged 21 commits into from
Dec 16, 2024
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
933438d
updates version on README.md
jdhg-orbiware Dec 9, 2024
50fd86a
github: fix typo
jdhg-orbiware Dec 9, 2024
5dbb196
github: fix typo in shellcheck action
jdhg-orbiware Dec 9, 2024
2be5238
github: shellcheck severity to warning
jdhg-orbiware Dec 9, 2024
302dfb9
github: shellcheck exclude some rules
jdhg-orbiware Dec 9, 2024
7c02c91
github: shellcheck exclude SC3037
jdhg-orbiware Dec 9, 2024
7e6a9fa
[WIP] shellcheck linting
jdhg-orbiware Dec 9, 2024
8808e8a
[WIP] shellcheck linting
jdhg-orbiware Dec 9, 2024
b6bf75a
[WIP] shellcheck linting
jdhg-orbiware Dec 9, 2024
7927385
[WIP] shellcheck linting
jdhg-orbiware Dec 9, 2024
7c000a0
[WIP] shellcheck linting
jdhg-orbiware Dec 9, 2024
d708a34
shellcheck: template, fix quotes
jdhg-orbiware Dec 9, 2024
097ad8e
shellcheck: template, revert single quotes
jdhg-orbiware Dec 10, 2024
7bad37c
shellcheck: export, mount. Logic syntax
jdhg-orbiware Dec 10, 2024
763184a
shellcheck: disable=SC2046 on verify.sh
jdhg-orbiware Dec 15, 2024
fd175fd
shellcheck: disable=SC2046 on verify.sh pt2
jdhg-orbiware Dec 15, 2024
63964b1
shellcheck: disable=SC3003 on verify.sh
jdhg-orbiware Dec 15, 2024
a906f14
shellcheck: fix double quote on `update TEMPLATES`
jdhg-orbiware Dec 15, 2024
124e968
shellcheck: fix zfs intentional '@' and disable SC2140
jdhg-orbiware Dec 15, 2024
78d2ae9
shellcheck: fix create intentional '@' and disable SC2140
jdhg-orbiware Dec 15, 2024
8893084
shellcheck: mount. Style: indication of line continuation
jdhg-orbiware Dec 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
github: shellcheck exclude some rules
jdhg-orbiware committed Dec 9, 2024
commit 302dfb972078fd8af15818d5c7e7d12a2e0fd2c0
6 changes: 5 additions & 1 deletion .github/workflows/shellcheck.yml
Original file line number Diff line number Diff line change
@@ -16,8 +16,12 @@ jobs:

- name: Run ShellCheck
uses: ludeeus/[email protected]
env:
# Excluding SC3043: In POSIX sh, 'local' is undefined. Ignoring because local is a built-in command in FreeBSD
# Excluding SC2154: Variable is referenced but not assigned. Because we include files in the scripts
SHELLCHECK_OPTS: -e SC3043 -e SC2154
with:
severity: warning
scandir: "./usr/local/share/bastille"
additional_files: "./usr/local/bin/bastille"
ignore_paths: "./usr/local/share/bastille/templates"
ignore_paths: "./usr/local/share/bastille/templates ./usr/local/share/bastille/colors.pre.sh"