Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clone.sh - simplify "update_fstab" function #757

Closed
wants to merge 8 commits into from

Conversation

tschettervictor
Copy link
Collaborator

Due to a discussion in #666 it does not really make sense to include all of this code.

The only things that needs to be changed when cloning or renaming a jail, is the jail path. The code that is being removed make use of a complex set of instructions to replace a simple jail path.

It is much easier to grep the fstab file for the old jail path, and rename all instances that it finds to the new jail path.

@tschettervictor
Copy link
Collaborator Author

Tested and working as expected for me.

@bmac2
Copy link
Collaborator

bmac2 commented Dec 26, 2024

your PR for fixing cloning, #725 also changes the clone.sh file. Is this change in that PR also, or is it a separate change???? can we merge the two so testing cloning can be done once and pushed? or is there an issue with putting these two together since it is changes to the same file?

@tschettervictor

@tschettervictor
Copy link
Collaborator Author

I'll close this and add the changes to the other PR.

@tschettervictor tschettervictor deleted the patch-4 branch December 27, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants