accept only one arg on htop

BastilleBSD · Dec 17, 2024 · 9e8cd7b · 9e8cd7b
1 parent 42a6a29
commit 9e8cd7b
Showing 1 changed file with 6 additions and 17 deletions.
diff --git a/usr/local/share/bastille/htop.sh b/usr/local/share/bastille/htop.sh
@@ -42,33 +42,22 @@ case "$1" in
         ;;
 esac
 
-if [ $# -eq 0 ]; then
-    usage
-else
-    TARGET="${1}"
-    shift
-fi
-
-if [ "${TARGET}" = "ALL" ]; then
-    target_all_jails
-else
-    check_target_exists "${TARGET}"
-fi
-
-if [ $# -ne 0 ]; then
+# Accept only one argument.
+if [ $# -eq 0 ] || [ $# -gt 1 ]; then
     usage
 fi
 
+set_target_single "${1}"
 bastille_root_check
 
-for _jail in ${JAILS}; do
+for _jail in "${JAILS}"; do
     check_target_is_running "${_jail}"
-    bastille_jail_path=$(/usr/sbin/jls -j "${_jail}" path)
+    bastille_jail_path="$(/usr/sbin/jls -j "${_jail}" path)"
     if [ ! -x "${bastille_jail_path}/usr/local/bin/htop" ]; then
         error_notify "htop not found on ${_jail}."
     elif [ -x "${bastille_jail_path}/usr/local/bin/htop" ]; then
         info "[${_jail}]:"
-        jexec -l ${_jail} /usr/local/bin/htop
+        jexec -l "${_jail}" /usr/local/bin/htop
     fi
     echo -e "${COLOR_RESET}"
 done