Asset request type #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and replaces the code duplication with that model
tluijken
requested changes
Aug 22, 2024
stellar_rust_sdk/src/offers/mod.rs
Outdated
Comment on lines
130
to
131
| // assert_eq!(response.selling().asset_code().as_ref().unwrap(), SELLING_ASSET_CODE); | ||
| // assert_eq!(response.selling().asset_issuer().as_ref().unwrap(), SELLING_ASSET_ISSUER); |
There was a problem hiding this comment.
Is er een reden deze uit te quoten? Als de velden nog steeds bestaan zou ik deze check graag intact gelaten zien. Als ze niet mee bestaan mogen ze weg.
stellar_rust_sdk/src/offers/mod.rs
Outdated
Comment on lines
167
to
168
| // assert_eq!(record.selling().asset_code().as_ref().unwrap(), SELLING_ASSET_CODE); | ||
| // assert_eq!(record.selling().asset_issuer().as_ref().unwrap(), SELLING_ASSET_ISSUER); |
There was a problem hiding this comment.
Is er een reden deze uit te quoten? Als de velden nog steeds bestaan zou ik deze check graag intact gelaten zien. Als ze niet mee bestaan mogen ze weg.
|
Done manually on develop together |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for issue: AssetType struct in a Request Models module #98
#98