54 implement payments endpoint

[LeonardTibben]

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Payment endpoints

⤵️ What is the current behavior?

No payment endpoint functionality

🆕 What is the new behavior (if this is a feature change)?

N/A

💥 Does this PR introduce a breaking change?

no

🐛 Recommendations for testing

N/A

📝 Links to relevant issues/docs

🤔 Checklist before submitting

• All projects build
• Follows style guide lines
• Relevant documentation was updated
• Rebased onto current main

[tluijken]

Nice!

[tluijken]

Dit is zoals alle andere requests dit doen. Ik zou willen voorstellen hierdezelfde logica aan te houden:

        vec![
            self.cursor.as_ref().map(|c| format!("cursor={}", c)),
            self.limit.as_ref().map(|l| format!("limit={}", l)),
            self.order.as_ref().map(|o| format!("order={}", o)),
        ]
        .build_query_parameters()

[tluijken]

Suggested change

	fn get_query_parameters(&self) -> String {
	let mut params = String::new();
	if let Some(cursor) = self.cursor {
	params.push_str(&format!("cursor={}&", cursor));
	}
	if let Some(limit) = self.limit {
	params.push_str(&format!("limit={}&", limit));
	}
	if let Some(order) = &self.order {
	params.push_str(&format!("order={}&", order));
	}
	params.push_str(&format!("include_failed={}", self.include_failed));
	params
	}
	fn get_query_parameters(&self) -> String {
	vec![
	self.include_failed.as_ref().map(|s| format!("include_failed={}", s)),
	self.cursor.as_ref().map(|c| format!("cursor={}", c)),
	self.limit.as_ref().map(|l| format!("limit={}", l)),
	self.order.as_ref().map(|o| format!("order={}", o)),
	]
	.build_query_parameters()
	}

[tluijken]

Suggested change

	fn get_query_parameters(&self) -> String {
	let mut params = String::new();
	if let Some(cursor) = self.cursor {
	params.push_str(&format!("cursor={}&", cursor));
	}
	if let Some(limit) = self.limit {
	params.push_str(&format!("limit={}&", limit));
	}
	if let Some(order) = &self.order {
	params.push_str(&format!("order={}&", order));
	}
	params.push_str(&format!("include_failed={}", self.include_failed));
	params
	}
	fn get_query_parameters(&self) -> String {
	vec![
	self.include_failed.as_ref().map(|s| format!("include_failed={}", s)),
	self.cursor.as_ref().map(|c| format!("cursor={}", c)),
	self.limit.as_ref().map(|l| format!("limit={}", l)),
	self.order.as_ref().map(|o| format!("order={}", o)),
	]
	.build_query_parameters()
	}

[tluijken]

Suggested change

	fn get_query_parameters(&self) -> String {
	let mut params = String::new();
	if let Some(cursor) = self.cursor {
	params.push_str(&format!("cursor={}&", cursor));
	}
	if let Some(limit) = self.limit {
	params.push_str(&format!("limit={}&", limit));
	}
	if let Some(order) = &self.order {
	params.push_str(&format!("order={}&", order));
	}
	params
	}
	fn get_query_parameters(&self) -> String {
	vec![
	self.cursor.as_ref().map(|c| format!("cursor={}", c)),
	self.limit.as_ref().map(|l| format!("limit={}", l)),
	self.order.as_ref().map(|o| format!("order={}", o)),
	]
	.build_query_parameters()
	}

[tluijken]

This can be removed since we no longer use this.

[tluijken]

The path should have the same number as the percentage. 67 > 86