re-use static strings for paths #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejorritsma
approved these changes
Nov 27, 2023
| self.liquidity_pool | ||
| .as_ref() | ||
| .map(|lp| format!("liquidity_pool={}", lp)), | ||
| ].build_query_parameters() | ||
| } | ||
|
|
||
| fn build_url(&self, base_url: &str) -> String { |
There was a problem hiding this comment.
Seems like this function is largely the same accross endpoints.
Some format with "{}/{}/{}" and some with "{}/{}{}".
Maybe (in another PR) we can unify this one as well :D
There was a problem hiding this comment.
I would agree on that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Code refactoring
Currently, there a a
get_pathmethod added to theRequesttrait, which is only used internally within the request to get the path. This path is often shared between multiple requests sharing the same controller. I think this is a wrong design, and doesn't allow for a proper re-use of path strings, which we should define one, and use as a const value.🆕 What is the new behavior (if this is a feature change)?
The paths for a particular module are not defined as
constvalues, and can be re-used for multiple request reaching out to the same endpoint.💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
The unit-tests still cover the logic.
📝 Links to relevant issues/docs
🤔 Checklist before submitting