Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added iOS #1

Merged
merged 7 commits into from
Mar 25, 2024
Merged

Added iOS #1

merged 7 commits into from
Mar 25, 2024

Conversation

TimHoogstrate
Copy link
Contributor

No description provided.

mvanbeusekom
mvanbeusekom requested changes Mar 19, 2024
View reviewed changes
Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure of the plugin is not correct. Everything seems to be hosted inside the "example" directory, while the example should be a simple Flutter application demonstrating how to use the plugin.

example/ios/Runner/InstanceManager.h Outdated Show resolved Hide resolved
example/ios/Runner/InstanceManager.m Outdated Show resolved Hide resolved
mvanbeusekom
mvanbeusekom requested changes Mar 25, 2024
View reviewed changes
...id/src/test/kotlin/com/baseflow/flutter_instance_manager/FlutterInstanceManagerPluginTest.kt Outdated Show resolved Hide resolved
example/integration_test/plugin_integration_test.dart Outdated Show resolved Hide resolved
ios/flutter_instance_manager.podspec Outdated Show resolved Hide resolved
ios/flutter_instance_manager.podspec Outdated Show resolved Hide resolved
lib/flutter_instance_manager_method_channel.dart Outdated Show resolved Hide resolved
lib/flutter_instance_manager_platform_interface.dart Outdated Show resolved Hide resolved
test/flutter_instance_manager_test.dart Outdated Show resolved Hide resolved
test/flutter_instance_manager_method_channel_test.dart Outdated Show resolved Hide resolved
@mvanbeusekom mvanbeusekom marked this pull request as ready for review March 25, 2024 13:03
@mvanbeusekom mvanbeusekom self-requested a review March 25, 2024 14:15
@TimHoogstrate TimHoogstrate merged commit 4a39016 into main Mar 25, 2024
1 check passed
@TimHoogstrate
Copy link
Contributor Author

LVGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimHoogstrate @mvanbeusekom