Set ImageRenderMethodForWeb.HttpGet, as a default imageRenderMethodForWeb for flutter 3.27.0 compatibility workaround
#996
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set` as a default `imageRenderMethodForWeb` for flutter 3.27.0 compatibility workaround
ZiyadF296
approved these changes
Dec 16, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
ImageRenderMethodForWeb.HttpGet,as a defaultimageRenderMethodForWebfor flutter 3.27.0 compatibility workaround✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Workaround
Currently on flutter version 3.27.0, usage of cached_network_image causes
canvaskit.js:21 Uncaught (in promise) SecurityError: Failed to execute 'texImage2D' on 'WebGL2RenderingContext': The image element contains cross-origin data, and may not be loaded.errors🆕 What is the new behavior (if this is a feature change)?
Setting the
ImageRenderMethodForWeb.HttpGet,as a defaultimageRenderMethodForWebprevents the errors from being thrown, and the app doesn't crash.💥 Does this PR introduce a breaking change?
Yes, the default value is being changed, which can cause unexpected behavior on older flutter versions
🐛 Recommendations for testing
📝 Links to relevant issues/docs
https://github.com/Baseflow/flutter_cached_network_image/issues/995
https://github.com/flutter/flutter/issues/160127
🤔 Checklist before submitting