Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle contacts limited permission #1395

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Hari-07
Copy link

@Hari-07 Hari-07 commented Oct 10, 2024

The package wasn't currently handling the new CNAuthorizationStatusLimited introduce in ios18. Older versions of ios will remain unchanged. Here's a screen recording showcasing the change

  • ios 17.2
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-10-10.at.13.43.12.mp4
  • ios 18.0
Simulator.Screen.Recording.-.Logged.In.16.Pro.-.2024-10-10.at.13.46.09.mp4

List at least one fixed issue.

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

@Hari-07
Copy link
Author

Hari-07 commented Oct 10, 2024

The check failure of invoking prints seems to be from an old commit, not from my changes. Happy to remove them if required though

@kvenn
Copy link

kvenn commented Oct 14, 2024

Any update on when this would be merged? This looks good to me!

@levyanjos
Copy link

Any update on this? I have same issue with iOS 18

@HappyMakadiyaS
Copy link

Is there any update on this? As we have a client request for this feature.

@starshipcoder
Copy link

Any update ? Apple is deploying the 18.1 right now, I see customers with this issue

@amrgetment
Copy link

for those who want it before merging

dependency_overrides:
  # limited access on iOS 18 for contacts
  permission_handler_apple:
    git:
      url: https://github.com/sodality-tech/flutter-permission-handler.git
      ref: main
      path: permission_handler_apple

@inamhusain
Copy link

inamhusain commented Dec 20, 2024

What about Android 14? it is directly show granted status

@Hari-07
Copy link
Author

Hari-07 commented Dec 20, 2024

What about Android 14? it is directly show granted status

Better to file a separate issue. This PR doesnt touch android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants