-
-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds MacOS Support #1207
base: main
Are you sure you want to change the base?
Adds MacOS Support #1207
Conversation
…hing the single strategies
@mvanbeusekom is there anything I can do to help move this forward? @alex-melnyk I think the pipeline is now broken because of some deprecated material fields in the example app |
Yes, please help me fix the pipeline |
@alex-melnyk I think I cant directly contribute here, but I fixed the warnings over at alex-melnyk#1 |
@mvanbeusekom Are we waiting for anything else here? Seems like alex-melnyk#1 has fixed all warnings ✅ Could you please review it? In the meantime, is there a way I could temporarily use alex-melnyk#1 in my current project? Writing the following in permission_handler:
git: https://github.com/dkbast/flutter-permission-handler.git |
I believe you need to either add ref: main or remove the .git in the url |
Fixes linter warnings to fix pipeline
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1207 +/- ##
=======================================
Coverage 71.42% 71.42%
=======================================
Files 1 1
Lines 35 35
=======================================
Hits 25 25
Misses 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
You need to override dependencies to use your implementation, here is example: dependency_overrides:
# https://github.com/Baseflow/flutter-permission-handler/pull/1207
permission_handler:
git:
url: [email protected]:alex-melnyk/flutter-permission-handler.git
path: permission_handler
ref: master
# https://github.com/Baseflow/flutter-permission-handler/pull/1207
permission_handler_apple:
git:
url: [email protected]:alex-melnyk/flutter-permission-handler.git
path: permission_handler_apple
ref: master |
Thank you for the support! |
@mvanbeusekom bumping this up, as this PR would really help fixing a hole in the ecosystem, in terms of compatibility. |
hi @alex-melnyk what do you think about permission |
@mvanbeusekom Hello, could you please review this PR ? It's a really important features. Thanks :) |
Please, push it. |
@mvanbeusekom up please |
@mvanbeusekom Any chance you have any bandwidth to take a look a this PR? |
@mvanbeusekom This is crutial for our application, waiting now for around 6 months for this to be merged. |
This PR replaces this one for macOS platform support.
Pre-launch Checklist
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.md
to add a description of the change.///
).main
.dart format .
and committed any changes.flutter analyze
and fixed any errors.This PR is fixes for comments of:
#946