Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Throw LocationSignalLostException when GPS signal is lost #1617

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

orkun1675
Copy link

When the GPS signal is lost while listening for position updates we inform the listener using an exception called LocationSignalLostException. This allows listeners to be aware of position availability changes. The listener can catch and ignore this exception if it is not important to them. The listener knows the GPS signal is restored when they receive a new Position via the stream.

Fixes #1355.

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

@orkun1675
Copy link
Author

This feature requires changes in 4 plugins. I'm not sure how I can get the static analyzers to pass due to this inter-dependency. Any guidence would be appreciated.

Note that IIUC, once this PR is merged and updates to the 4 plugins are published to pub.dev the build errors will go away.

@orkun1675 orkun1675 changed the title Throw LocationSignalLostException when GPS signal is lost [Feature] Throw LocationSignalLostException when GPS signal is lost Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: A function that is called when GPS signal is lost.
1 participant