Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS]update isMocked documentation #1370

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TimHoogstrate
Copy link
Contributor

@TimHoogstrate TimHoogstrate commented Nov 8, 2023

Resolves: 1216

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5b07c28) to head (ccafe08).
Report is 81 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1370   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          244       244           
=========================================
  Hits           244       244           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimHoogstrate TimHoogstrate changed the title Documentation/is mocked [iOS]update isMocked documentation Nov 9, 2023
@OmarLajam
Copy link

This should be merged to update the documentation of isMocked on iOS 15+. The current documentation is misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isMocked is always false according to the documentation
2 participants