Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added macos implementation #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

riccardo-lomazzi
Copy link

@riccardo-lomazzi riccardo-lomazzi commented Oct 20, 2022

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

This commit introduces the MacOS implementation for the plugin.

⤵️ What is the current behavior?

Currently the MacOS integration isn't included.

🆕 What is the new behavior (if this is a feature change)?

Now it uses the same location services as iOS (complete with MacOS version availability checks) to provide geolocation.

💥 Does this PR introduce a breaking change?

No.

🐛 Recommendations for testing

📝 Links to relevant issues/docs

Creating a macos plugin also automatically created stub files for the other platforms implementations, e.g kotlin files in the android folder. These files can be safely removed.

🤔 Checklist before submitting

  • [ x] I made sure all projects build.
  • [x ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • [x ] I followed the style guide lines (code style guide).
  • [x ] I updated the relevant documentation.
  • [ x] I rebased onto current master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants