Some updates for MaterialTextField & MaterialSelectionControl #411
Conversation
Sample update for TrailingIconCommand + Parameter and TrailingIconSelected
Update for TrailingIconSelected
Update for TrailingIcon
Update for ChoiceCommandParameter and TrailingIcon Command + Parameter + Selected Event
Update for counter and choice selected placeholder font size
Update for horizontal orientation width size
Update for counter visibility behavior
|
Can you rebase to include the latest changes? @softlion can you check this PR? |
Hello @martijn00 and @softlion I am working new implementations now. I will push 30 minutes later. Please wait to check before this update. Thank you in advance. |
|
Hello again @martijn00 and @softlion I could push yet. Please check and accept PR. Also thank you for your good plugin. |
|
@kerberosargos I think you rebase went wrong, you have conflicts. |
|
Hello @martijn00 I have merged conflict, please check again. |
kerberosargos
changed the title
|
Hello @martijn00 can you check this PR please? |
…te if value is true when text changed event
|
@softlion Can you check this one before i merge it? |
|
Hello again can you check and merge please? |
|
Hello @martijn00 and @softlion can you check this pr please? |
| @@ -14,7 +14,7 @@ protected override void OnCreate(Bundle savedInstanceState) | |||
| ToolbarResource = Resource.Layout.Toolbar; | |||
|
|
|||
| base.OnCreate(savedInstanceState); | |||
| Rg.Plugins.Popup.Popup.Init(this, savedInstanceState); | |||
| Rg.Plugins.Popup.Popup.Init(this); | |||
There was a problem hiding this comment.
Why has this been removed ?
There was a problem hiding this comment.
if you do not remove "savedInstanceState" Rg.Plugins.Popup gives compile error.
| <None Remove="Images\eye-slash-solid-18dp.svg" /> | ||
| <None Remove="Images\eye-solid-18dp.svg" /> |
There was a problem hiding this comment.
I have added new icon for password show hide example.
|
|
||
| public MaterialTextFieldViewModel() | ||
| { | ||
| OpenCustomChoiceCommand = new Command(async () => | ||
| { | ||
| await MaterialDialog.Instance.AlertAsync("Command tapped. Do what you want ! You can open a custom popup, ask some data, and update the textfield text with this data"); | ||
| }); | ||
|
|
||
| CustomChoiceParameterUsingCommand = new Command<MaterialTextField>(async (e) => |
There was a problem hiding this comment.
a viewmodel should not receive a UI object. Using MaterialTextField, which is a UI object, as a parameter is a very bad practive. Instead create a new class with the interesting parameters only.
To change a property of a ui item, use binding and datatriggers instead.
There was a problem hiding this comment.
That is a sample for testing ChoiceCommandParameter. I use this approach for example hide show datepicker for cross platform. Whay do you think that is not good practive?
| @@ -17,6 +17,7 @@ | |||
| <PackageId>XF.Material</PackageId> | |||
| <Description>A Xamarin.Forms library for Xamarin.Android and Xamarin.iOS to implement Google's Material Design.</Description> | |||
| <DisableFastUpToDateCheck>true</DisableFastUpToDateCheck> | |||
| <Version>1.7.7.1</Version> | |||
There was a problem hiding this comment.
remove this, as it may be set by a batch ?
There was a problem hiding this comment.
This is my first pull request. So I am newbie. All comment is for me or @softlion? Thank you for your interest.
There was a problem hiding this comment.
Hello will you get this pr? @softlion @martijn00
This pull request includes added ChoiceCommandParameter for MVVM using and changes for TrailingIcon.
Developer can set Command and CommandParamater or Tap event to TrailingIcon for example show or hide password behavior.