Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin version #772

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Kotlin version #772

wants to merge 13 commits into from

Conversation

marquessbr
Copy link

Here is all photoview files migrated to kotlin

added return to the end of file
added return to the end of file
added return to the end of file
added return to the end of file
added return to the end of file
added return to the end of file
added return to the end of file
added return to the end of file
added return to the end of file
added return to the end of file
added return to the end of file
Copy link
Author

@marquessbr marquessbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added return to the end of any file which I always forget

@marquessbr
Copy link
Author

here is the kotlin version

@marquessbr marquessbr mentioned this pull request Sep 19, 2020
@DatL4g
Copy link

DatL4g commented Oct 21, 2020

The Kotlin Files are all in the wrong directory.
This is unusable.

@marquessbr
Copy link
Author

The Kotlin Files are all in the wrong directory.
This is unusable.

Hi
I am new in github, so, how I can make this correct? you can help-me?

@DatL4g
Copy link

DatL4g commented Oct 23, 2020

Hi
I am new in github, so, how I can make this correct? you can help-me?

Just replace the current Java files with your Kotlin files.
Your Kotlin files are currently under photoview/ and the Java files are located under photoview/src/main/java/com/github/chrisbanes/photoview/
In your fork

@marquessbr
Copy link
Author

Hi
I am new in github, so, how I can make this correct? you can help-me?

Just replace the current Java files with your Kotlin files.
Your Kotlin files are currently under photoview/ and the Java files are located under photoview/src/main/java/com/github/chrisbanes/photoview/
In your fork

Hi @DatL4g sorry for later response, workin here I don't know how I can do that, sorry

@Goooler
Copy link

Goooler commented Nov 4, 2020

Your code is ugly, close the PR plz

@marquessbr
Copy link
Author

Your code is ugly, close the PR plz

you are crazy man, this is not java but kotlin, watch well before saying something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants