Temporarily detach value listeners. (#1030)

BartoszCichecki · Nov 9, 2023 · 7971907 · 7971907
1 parent 115bbb3
commit 7971907
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/LenovoLegionToolkit.WPF/Windows/Dashboard/GodModeSettingsWindow.xaml b/LenovoLegionToolkit.WPF/Windows/Dashboard/GodModeSettingsWindow.xaml
@@ -130,16 +130,14 @@
                         Title="{x:Static resources:Resource.GodModeSettingsWindow_CPU_LongTermPL}"
                         Margin="0,0,0,8"
                         Description="{x:Static resources:Resource.GodModeSettingsWindow_CPU_LongTermPL_Description}"
-                        Unit="W"
-                        ValueChanged="CpuLongTermPowerLimitSlider_ValueChanged" />
+                        Unit="W" />
 
                     <godMode:GodModeValueControl
                         x:Name="_cpuShortTermPowerLimitControl"
                         Title="{x:Static resources:Resource.GodModeSettingsWindow_CPU_ShortTermPL}"
                         Margin="0,0,0,8"
                         Description="{x:Static resources:Resource.GodModeSettingsWindow_CPU_ShortTermPL_Description}"
-                        Unit="W"
-                        ValueChanged="CpuShortTermPowerLimitSlider_ValueChanged" />
+                        Unit="W" />
 
                     <godMode:GodModeValueControl
                         x:Name="_cpuPeakPowerLimitControl"

diff --git a/LenovoLegionToolkit.WPF/Windows/Dashboard/GodModeSettingsWindow.xaml.cs b/LenovoLegionToolkit.WPF/Windows/Dashboard/GodModeSettingsWindow.xaml.cs
@@ -152,6 +152,9 @@ private async Task<bool> ApplyAsync()
 
     private async Task SetStateAsync(GodModeState state)
     {
+        _cpuLongTermPowerLimitControl.ValueChanged -= CpuLongTermPowerLimitSlider_ValueChanged;
+        _cpuShortTermPowerLimitControl.ValueChanged -= CpuShortTermPowerLimitSlider_ValueChanged;
+
         var activePresetId = state.ActivePresetId;
         var preset = state.Presets[activePresetId];
 
@@ -160,7 +163,6 @@ private async Task SetStateAsync(GodModeState state)
         _addPresetsButton.IsEnabled = state.Presets.Count < 5;
         _deletePresetsButton.IsEnabled = state.Presets.Count > 1;
 
-
         _cpuLongTermPowerLimitControl.Set(preset.CPULongTermPowerLimit);
         _cpuShortTermPowerLimitControl.Set(preset.CPUShortTermPowerLimit);
         _cpuPeakPowerLimitControl.Set(preset.CPUPeakPowerLimit);
@@ -246,6 +248,9 @@ private async Task SetStateAsync(GodModeState state)
         _fanSectionTitle.Visibility = fanSectionVisible ? Visibility.Visible : Visibility.Collapsed;
         _advancedSectionTitle.Visibility = advancedSectionVisible ? Visibility.Visible : Visibility.Collapsed;
         _advancedSectionMessage.Visibility = advancedSectionVisible ? Visibility.Visible : Visibility.Collapsed;
+
+        _cpuLongTermPowerLimitControl.ValueChanged += CpuLongTermPowerLimitSlider_ValueChanged;
+        _cpuShortTermPowerLimitControl.ValueChanged += CpuShortTermPowerLimitSlider_ValueChanged;
     }
 
     private async void SetDefaults(GodModeDefaults defaults)