Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update munit-scalacheck to 1.0.0 #422

Merged
merged 3 commits into from
May 24, 2024
Merged

Conversation

banno-diy-steward[bot]
Copy link

About this PR

πŸ“¦ Updates org.scalameta:munit-scalacheck from 0.7.29 to 1.0.0 ⚠

πŸ“œ GitHub Release Notes

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scalameta", artifactId = "munit-scalacheck" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta", artifactId = "munit-scalacheck" }
}]
labels: test-library-update, early-semver-major, semver-spec-major, commit-count:1

@banno-diy-steward banno-diy-steward bot requested a review from a team as a code owner May 22, 2024 16:07
@samspills
Copy link
Contributor

I've bumped our version of scalacheck-effect-munit to use the most recently released milestone v2.0.0-M2, which targets munit 1.0-M11. This allows us to bump to munit 1.0 here.

I looked briefly at bumping scalacheck-effect to munit 1.0 but it looks like that update will also involve updating scala-native so I backed away pretty quickly. I think merging this with the milestone is okay, but happy to hear dissent

Copy link
Collaborator

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is scala-native even relevant here? Regardless, it's just a test dependency, so Green Is Good.

@samspills samspills merged commit 1493d4a into main May 24, 2024
7 checks passed
@samspills samspills deleted the update/munit-scalacheck-1.0.0 branch May 24, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants