Make generateSecret more robust #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Handle non-200 successes 2. Attempt recovery if the body is malformed/omitted
morgen-peschke
requested review from
rossabaker,
samspills and
ChristopherDavenport
bannopeter
reviewed
Oct 24, 2023
rossabaker
approved these changes
Oct 30, 2023
|
|
||
| test( | ||
| "generateSecret works as expected when receiving a 200 Ok with an unparsable response" | ||
| ) { |
There was a problem hiding this comment.
I'm lost what made that test unparsable.
There was a problem hiding this comment.
The third type argument to generateSecret on line 697 doesn't match the second, so it's putting in a SelfManaged and trying to pull it back out as a VaultKeys (which has an incompatible serialization).
morgen-peschke
deleted the
ISSUE-392-increase-generate-secret-robustness
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #392