Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to confluent 7.4.1 #772

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Upgrade to confluent 7.4.1 #772

merged 3 commits into from
Aug 21, 2023

Conversation

zcox
Copy link
Collaborator

@zcox zcox commented Aug 18, 2023

@zcox zcox requested a review from a team as a code owner August 18, 2023 19:52
amohrland
amohrland approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@amohrland amohrland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@amohrland
Copy link
Collaborator

We really ought to bring back our

addCommandAlias("ffs", "scalafmtSbt;scalafmtAll;")

alias.

@rossabaker
Copy link
Contributor

This looks good, but I'm not sure it's going to get us out of the vulnerable Guava mess:

https://github.com/confluentinc/common/blob/v7.4.1/pom.xml#L64

@zcox zcox merged commit a98c20f into Banno:master Aug 21, 2023
2 checks passed
@zcox zcox deleted the confluent-7.4.1 branch August 21, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amohrland amohrland amohrland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zcox @amohrland @rossabaker