This repository has been archived by the owner on Sep 24, 2023. It is now read-only.
Add multi default orgs #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 19, 2018 16:13
|
any news ? |
|
I'm not sure, that it's sofisticated. From my point of view the mapping should happens on LDAP group level, like: AUTH_LDAP_DEFAULT_SENTRY_ORGANIZATION = {
ldap_group_x: [u'Sentry organization x'],
} |
barronhagerman
suggested changes
Jan 17, 2020
| organizations = Organization.objects.filter(name=org) | ||
| if not organizations or len(organizations) < 1: | ||
| continue | ||
| self._add_user_in_organization(organizations[0], user, member_role, has_global_access) |
There was a problem hiding this comment.
Shouldn't this be
Suggested change
| self._add_user_in_organization(organizations[0], user, member_role, has_global_access) | |
| self._add_user_in_organization(org, user, member_role, has_global_access) |
| @@ -82,3 +74,13 @@ def get_or_create_user(self, username, ldap_user): | |||
| ) | |||
|
|
|||
| return model | |||
|
|
|||
| def _add_user_in_organization(self, organizations, user, member_role, has_global_access): | |||
There was a problem hiding this comment.
nit.. rename organizations to org
Suggested change
| def _add_user_in_organization(self, organizations, user, member_role, has_global_access): | |
| def _add_user_in_organization(self, org, user, member_role, has_global_access): |
| def _add_user_in_organization(self, organizations, user, member_role, has_global_access): | ||
| # Add the user to the organization with global access | ||
| OrganizationMember.objects.create( | ||
| organization=organizations, |
There was a problem hiding this comment.
Suggested change
| organization=organizations, | |
| organization=org, |
|
@sergeohl any chance to see improvements on this PR soon? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I add a way to subscribe in several organizations by default.
Like that: